-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor,planner: fix update join update unmatched outer row #23491
Conversation
/run-all-tests |
updt.PartitionedTable = b.partitionedTable | ||
updt.tblID2Table = tblID2table |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tblID2Table
is built twice, once in PlanBuilder.buildUpdate
building from tblID2Handle
, another is in executorBuilder.buildUpdate
building from TblColPosInfos
. And they are quite similar.
Can we remove the one in Update
plan, if the only usage of Update.tblID2Table
is for CheckUpdateList
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dyzsr great idea, but it seems executorBuilder.buildUpdate take care more about partitions?
how about add another issue to improve it? this's PR is release-block bugfix, introduce addition modification is high risk
/lgtm |
/lgtm |
@dyzsr: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Co-authored-by: tangenta <tangenta@126.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c3d8567
|
/merge |
/rebuild |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #23596 |
What problem does this PR solve?
Issue Number: close #23482
Problem Summary:
What is changed and how it works?
What's Changed, How it Works:
UpdateExec.prepare
(called for each row) setUpdateExec.updatable
with right valueis it NULL row generated by unmatched outer row
Related changes
Check List
Tests
Side effects
Release note
This change is